Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug that prevents pass_through_columns to be propagated in macros #5

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Bug that prevents pass_through_columns to be propagated in macros #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e1c7e9
Update get_ad_group_report_hourly_columns.sql
andysmv Dec 30, 2022
b0c9e96
Update get_ad_report_hourly_columns.sql
andysmv Dec 30, 2022
2a63199
Update get_campaign_report_hourly_columns.sql
andysmv Dec 30, 2022
be78260
Update CHANGELOG.md
fivetran-joemarkiewicz Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@
- `dbt.current_timestamp_backcompat`
- `dbt.current_timestamp_in_utc_backcompat`
- `packages.yml` has been updated to reflect new default `fivetran/fivetran_utils` version, previously `[">=0.3.0", "<0.4.0"]` now `[">=0.4.0", "<0.5.0"]`.

## Bug Fixes
- Adjusted the `get_ad_group_report_hourly_columns`, `get_ad_report_hourly_columns`, and `get_campaign_report_hourly_columns` macros to ensure the passthrough variables are included in the returned columns and propogate within downstream models. ([#5](https://github.com/fivetran/dbt_tiktok_ads_source/pull/5))

## Contributors
- [@andysmv](https://github.com/andysmv) ([#5](https://github.com/fivetran/dbt_tiktok_ads_source/pull/5))

# dbt_tiktok_ads_source v0.2.0
PR [#3](https://github.com/fivetran/dbt_tiktok_ads_source/pull/3) applies the following updates:
## 🎉 Feature Enhancements 🎉
Expand Down
6 changes: 3 additions & 3 deletions macros/get_ad_group_report_hourly_columns.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
{"name": "video_watched_6_s", "datatype": dbt.type_numeric()}
] %}

{{ return(columns) }}

{{ fivetran_utils.add_pass_through_columns(columns, var('tiktok_ads__ad_group_hourly_passthrough_metrics')) }}

{% endmacro %}
{{ return(columns) }}

{% endmacro %}
6 changes: 3 additions & 3 deletions macros/get_ad_report_hourly_columns.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
{"name": "video_watched_6_s", "datatype": dbt.type_numeric()}
] %}

{{ return(columns) }}

{{ fivetran_utils.add_pass_through_columns(columns, var('tiktok_ads__ad_hourly_passthrough_metrics')) }}

{% endmacro %}
{{ return(columns) }}

{% endmacro %}
6 changes: 3 additions & 3 deletions macros/get_campaign_report_hourly_columns.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
{"name": "video_watched_6_s", "datatype": dbt.type_numeric()}
] %}

{{ return(columns) }}

{{ fivetran_utils.add_pass_through_columns(columns, var('tiktok_ads__campaign_hourly_passthrough_metrics')) }}

{% endmacro %}
{{ return(columns) }}

{% endmacro %}