Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DocsQAWithSources component #207

Merged
merged 11 commits into from
Jul 21, 2023
Merged

Add DocsQAWithSources component #207

merged 11 commits into from
Jul 21, 2023

Conversation

mdepinet
Copy link
Contributor

This extends on DocsQA by encouraging the LLM to provide sources for its answer and allowing the developer to format the result as they like.

@mdepinet mdepinet self-assigned this Jul 21, 2023
@vercel
Copy link

vercel bot commented Jul 21, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai-jsx-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 6:50pm
ai-jsx-nextjs-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 6:50pm
ai-jsx-tutorial-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 6:50pm

farzadab
farzadab approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@farzadab farzadab left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense!
I put in some minor comments, but otherwise LGTM.

It's interesting that the whole GPT revolution started with getting free-form text and now we're all going back to forcing structure :)

packages/docs/docs/guides/docsqa.md Outdated Show resolved Hide resolved
packages/docs/docs/guides/docsqa.md Outdated Show resolved Hide resolved
packages/ai-jsx/src/batteries/docs.tsx Outdated Show resolved Hide resolved
mdwelsh
mdwelsh approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@mdwelsh mdwelsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mdepinet mdepinet mentioned this pull request Jul 21, 2023
Merged
@mdepinet mdepinet enabled auto-merge (squash) July 21, 2023 18:53
@mdepinet mdepinet merged commit 80e25c7 into main Jul 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickHeiner NickHeiner NickHeiner approved these changes

@mdwelsh mdwelsh mdwelsh approved these changes

@farzadab farzadab farzadab approved these changes

Assignees

@mdepinet mdepinet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdepinet @NickHeiner @mdwelsh @farzadab