Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise TypeError when given argument is not supported #282

Merged
merged 4 commits into from
Mar 11, 2020
Merged

Raise TypeError when given argument is not supported #282

merged 4 commits into from
Mar 11, 2020

Conversation

y1r
Copy link
Collaborator

@y1r y1r commented Mar 11, 2020

Resolves discussion in #281 (comment)

y1r added 2 commits March 11, 2020 03:06
@y1r
Add test
5d5ffa4
@y1r
Bugfix of _launch.
44de6d3 
When given `a` doesn't support buffer protocol, the previous code raises AttributeError but TypeError should be raised.
@y1r
Copy link
Collaborator Author

y1r commented Mar 11, 2020

@nsakabe-fixstars Could you review this PR?

jenkins-maekawa
jenkins-maekawa approved these changes Mar 11, 2020
View reviewed changes
Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit 110a787) passed on titanv.

@y1r y1r mentioned this pull request Mar 11, 2020
Merged
jenkins-maekawa
jenkins-maekawa approved these changes Mar 11, 2020
View reviewed changes
Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit 110a787) passed on vega.

jenkins-maekawa
jenkins-maekawa approved these changes Mar 11, 2020
View reviewed changes
Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit 110a787) passed on titanv.

jenkins-maekawa
jenkins-maekawa approved these changes Mar 11, 2020
View reviewed changes
Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit 110a787) passed on vega.

jenkins-maekawa
jenkins-maekawa approved these changes Mar 11, 2020
View reviewed changes
Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit a61fb54) passed on titanv.

@LWisteria LWisteria added the bug Something isn't working label Mar 11, 2020
jenkins-maekawa
jenkins-maekawa approved these changes Mar 11, 2020
View reviewed changes
Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit a61fb54) passed on vega.

nsakabe-fixstars
nsakabe-fixstars approved these changes Mar 11, 2020
View reviewed changes
Copy link

@nsakabe-fixstars nsakabe-fixstars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsakabe-fixstars nsakabe-fixstars merged commit 30a7193 into clpy Mar 11, 2020
@nsakabe-fixstars nsakabe-fixstars deleted the 153-fix-type-check branch March 11, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsakabe-fixstars nsakabe-fixstars nsakabe-fixstars approved these changes

@jenkins-maekawa jenkins-maekawa jenkins-maekawa approved these changes

Assignees

@nsakabe-fixstars nsakabe-fixstars

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@y1r @nsakabe-fixstars @jenkins-maekawa @LWisteria