AMD support, Auto-fetch credentials from Collection/Model url

[ghost]

• Added AMD support
• Automatically fetch basic auth credentials from Collection/Model url property
• Improved library documentation

[fiznool]

Very nice. Thanks for the PR.

I wonder if there is merit in keeping the explicit set and clear functions, in case the developer wants to set BasicAuth this way. Then you have the choice of URL-based or function-based. What do you think?

[ghost]

Dunno, what would be the use case? Would it help based on your experience?

To me it feels like setting the url property ( or a value read by a function assigned to it ) would replace both set and clear, no extra apis to learn about. ( I was actually expecting Backbone to already have this behavior )

What do you think?

[fiznool]

Dunno, what would be the use case? Would it help based on your experience?

I'm not really sure... I think the URL based approach will fit, and thinking about it, it is the correct way of doing things, according to the Basic Auth spec. I was also thinking of keeping set and clear for backwards compatibility, but its a 0. release, so its reasonable to expect breaking changes.

Before I pull in, just wanted to check - does the code take care of removing the username:password cleartext from the URL before making the remote request? I can't see where this might be happening, but I might just be blind.

[ghost]

Ah, that's a good point, backwards compat, but as you say, it's not a minor release.

The credentials are stripped away by jQuery already.

Luis - @lmjabreu

On 5 Jul 2013, at 11:24, Tom Spencer notifications@github.com wrote:

Dunno, what would be the use case? Would it help based on your experience?

I'm not really sure... I think the URL based approach will fit, and thinking about it, it is the correct way of doing things, according to the Basic Auth spec. I was also thinking of keeping set and clear for backwards compatibility, but its a 0. release, so its reasonable to expect breaking changes.

Before I pull in, just wanted to check - does the code take care of removing the username:password cleartext from the URL before making the remote request? I can't see where this might be happening, but I might just be blind.

—
Reply to this email directly or view it on GitHub.

[fiznool]

Sorry this has taken so long, now merged in. I decided to use Backbone.sync instead of overriding the individual Collection and Model sync methods, as I quite often find myself overriding an individual Model or Collection sync method, and I would probably forget to call the superclass...

Thanks too for providing the AMD code. Please let me know if you find any issues with the newest version.