Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parseHeader total (instead of failing when decoding) #30

Merged
merged 1 commit into from
Jul 23, 2016
Merged

Make parseHeader total (instead of failing when decoding) #30

merged 1 commit into from
Jul 23, 2016

Conversation

berdario
Copy link
Contributor

@berdario berdario commented Jul 23, 2016 •
edited
Loading

current behavior:

> parseHeader "\250\250" :: Either Text Text
Right "*** Exception: Cannot decode byte '\xfa': Data.Text.Internal.Encoding.decodeUtf8: Invalid UTF-8 stream

With my patch:

> parseHeader "\250\250" :: Either Text Text
Left "Cannot decode byte '\\xfa': Data.Text.Internal.Encoding.decodeUtf8: Invalid UTF-8 stream"

@berdario berdario changed the title Make toHeader total (instead of failing when decoding) Make parseHeader total (instead of failing when decoding) Jul 23, 2016
@fizruk fizruk merged commit 6ec0d6c into fizruk:master Jul 23, 2016
@fizruk
Copy link
Owner

fizruk commented Jul 23, 2016

Thanks! Sorry for the weird CI, I've switched to Stack-based builds now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@berdario @fizruk