Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parseHeader total (instead of failing when decoding) #30

Merged
merged 1 commit into from Jul 23, 2016

Conversation

Projects
None yet
2 participants
@berdario
Copy link
Contributor

commented Jul 23, 2016

current behavior:

> parseHeader "\250\250" :: Either Text Text
Right "*** Exception: Cannot decode byte '\xfa': Data.Text.Internal.Encoding.decodeUtf8: Invalid UTF-8 stream

With my patch:

> parseHeader "\250\250" :: Either Text Text
Left "Cannot decode byte '\\xfa': Data.Text.Internal.Encoding.decodeUtf8: Invalid UTF-8 stream"

@berdario berdario force-pushed the berdario:master branch from 5391e54 to 6ec0d6c Jul 23, 2016

@berdario berdario changed the title Make toHeader total (instead of failing when decoding) Make parseHeader total (instead of failing when decoding) Jul 23, 2016

@fizruk fizruk merged commit 6ec0d6c into fizruk:master Jul 23, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@fizruk

This comment has been minimized.

Copy link
Owner

commented Jul 23, 2016

Thanks! Sorry for the weird CI, I've switched to Stack-based builds now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.