Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ToHttpApiData instances for time types #53

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Fix ToHttpApiData instances for time types #53

merged 2 commits into from
Apr 21, 2017

Conversation

fizruk
Copy link
Owner

@fizruk fizruk commented Apr 21, 2017

Closes #48 and closes #41.

This PR also introduces ToHttpApiData and FromHttpApiData instances for TimeOfDay.

@fizruk fizruk merged commit e5b2414 into master Apr 21, 2017
@fizruk fizruk deleted the fix-time branch April 21, 2017 07:03
@phadej
Copy link
Collaborator

phadej commented Apr 21, 2017

Remember to update changelog!

@fizruk
Copy link
Owner Author

fizruk commented Apr 21, 2017

@phadej thanks for the reminder! I usually do changelog in a release branch (see 5158283).

Regarding quickcheck-instances — maybe, but it was easier this time for me to just adjust what we had a little. Would quickcheck-instances make our tests more reliable?

@phadej
Copy link
Collaborator

phadej commented Apr 21, 2017

@fizruk well, at least aeson uses it; so at least the impl will be "broken" in the same way :)

@fizruk
Copy link
Owner Author

fizruk commented Apr 21, 2017

Ah, that's a good argument!

@fizruk fizruk mentioned this pull request Apr 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UTCTime loses precision. Make HttpApiData representation for ZonedTime consistent with aeson
2 participants
@fizruk @phadej