Fix Issue #59 #74
Fix Issue #59 #74
Conversation
…ild project because of cabal-doctest-1. It recommeded that I add the latest matching version in the extra-deps.
…ild project because of cabal-doctest-1. It recommeded that I add the latest matching version in the extra-deps.
src/Web/Internal/HttpApiData.hs
Outdated
| @@ -530,6 +532,15 @@ instance (ToHttpApiData a, ToHttpApiData b) => ToHttpApiData (Either a b) where | |||
| toUrlPiece (Left x) = "left " <> toUrlPiece x | |||
| toUrlPiece (Right x) = "right " <> toUrlPiece x | |||
|
|
|||
| -- | | |||
| -- >>> Right c = parseUrlPiece "PHPSESSID=r2t5uvjq435r4q7ib3vtdjq120" :: Either Text SetCookie | |||
There was a problem hiding this comment.
and please, something else than PHPSESSID :)
stack.yaml
Outdated
| @@ -9,4 +9,5 @@ flags: | |||
|
|
|||
| extra-deps: | |||
| - attoparsec-iso8601-1.0.0.0 | |||
| extra-package-dbs: [] | |||
| - cabal-doctest-1.0.6 | |||
| extra-package-dbs: [] | |||
There was a problem hiding this comment.
rather updated a resolver to lts-11.0
There was a problem hiding this comment.
I had originally done that but I wasn't too sure of the impact it would have so I opt to just add it to the extra-deps. So, I'm pretty much not too about the difference between adding the dependencies in extra-deps and updating using the resolver.
http-api-data.cabal
Outdated
| @@ -52,7 +52,8 @@ library | |||
| , time-locale-compat >= 0.1.1.0 && < 0.2 | |||
| , unordered-containers >= 0.2.6.0 && < 0.3 | |||
| , uri-bytestring >= 0.1.7 && < 0.4 | |||
| , uuid-types >= 1.0.2 && <1.1 | |||
| , uuid-types >= 1.0.2 && < 1.1 | |||
| , cookie >= 0.4 && < 0.4.4 | |||
There was a problem hiding this comment.
I changed it to >= 0.4 && < 0.45 or it would complain again asking to set - cookie-0.4.3
in the extra-deps.
|
Also, if you can please rebase, don't merge master. Merging unnecessarily clutters history (EDIT: although, we can just squash & merge) |
|
Yes, I just rebased it on my local machine. Wasn't too sure what happened.. but learned from it. Thank you. I will proceed with your requested changes! |
…ve updated resolver to lts-11.0. Removed any notion of PHP....
Hi guys,
I have added the instances for SetCookie related to issue #59. Please let me know if anything needs adjusting.
Will be waiting for your feedback. Thanks!