Fix response parsing in UpdatingMessages #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Response to editMessage* requests is either "true", indicating that the edited message has been inline, or a message otherwise. This was (intuitively) represented with Either Bool Message. However, Aeson understands this as a literal sum type of Left _ | Right _, which is not the intended semantics. Replace Either with a custom data type which exhibits the proper parsing behaviour.
|
Tested with |
|
Cool stuff, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to editMessage* requests is either
"true", indicating that the edited message has been inline, or a message otherwise. This was (intuitively) represented withEither Bool Message. However, Aeson understands this as a literal sum type ofLeft _ | Right _, which is not the intended semantics. ReplaceEitherwith a custom data type which exhibits the proper parsing behaviour.Fixes #130