Implement sendDocument function support. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendDocument is implemented as a special wrapper that decide what content type to use based on the query content. Such approach is not servant-client friendly, so we ToMultipart function becomes partial, but it may be ok, as other solutions would require manual copy of the types and it will be much harder to follow. Fixes fizruk#30.
|
Proceeding with merge! @qnikst, thank you for your contribution! |
This was referenced Feb 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendDocument is implemented as a special wrapper that decide
what content type to use based on the query content. Such approach
is not servant-client friendly, so we ToMultipart function becomes
partial, but it may be ok, as other solutions would require manual
copy of the types and it will be much harder to follow.
Fixes #30.
This commit includes patch from the other, I can exclude that as soon as it will be merged.