Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no_std feature #19

Closed
newpavlov opened this issue Sep 14, 2016 · 5 comments
Closed

Remove no_std feature #19

newpavlov opened this issue Sep 14, 2016 · 5 comments

Comments

@newpavlov
Copy link
Contributor

newpavlov commented Sep 14, 2016

no_std feature got deprecated in typenum and this crate does not use it at all, so there is no reason to keep it.

P.S.: Also this issue will be a good reason to bump a minor version. ;)

@fizyk20
Copy link
Owner

fizyk20 commented Sep 14, 2016

Makes sense, thanks :) Won't it conflict with crates using std, though? From what I could gather, it looks like it won't, but I need to make sure ;)

Oh, and by the way - why 0.5.1 and not 0.5.0 in the PR?

@newpavlov
Copy link
Contributor Author

newpavlov commented Sep 15, 2016

Won't it conflict with crates using std, though?

I've used no_std crates from std ones, no problems so far. I will be very surprised if such problem arise and I think we should qualify it as a bug.

Oh, and by the way - why 0.5.1 and not 0.5.0 in the PR?

My mistake, will fix it.

@fizyk20
Copy link
Owner

fizyk20 commented Sep 15, 2016

Awesome, thanks :)

@bluss
Copy link

bluss commented Sep 28, 2016

Nodrop links to std by default as well (you can opt out).

It's hard to get rid of std..

@bluss
Copy link

bluss commented Sep 28, 2016

Since the previous no_std feature in your crate was subtractive, I'll put in a reminder that crate features need to be additive due to how they work in cargo. Nodrop has an example of this, std is an additive (but default) feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants