-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mem::uninitialized is nearly always UB, switch to MaybeUninitialized or something else #89
Comments
I've been meaning to do this, and will try to get to it soon. Thanks for reminding me. |
Ugh, I hadn't touched the repo in a few months and wasn't paying attention to which remote I was pushing to, so now the initial implementation with @fizyk20 Do you have any feedback for this implementation? A few things of note:
Technically these are not breaking changes, and do not affect the external API. |
From what I can tell this has already been fixed and merged to |
I was waiting on @fizyk20 's response, but they don't seem active on this repo anymore. I'll see about double-checking the code and pushing a version update when I have time in the next few days. |
When @fizyk20 is no longer active on the repo, how can we effectively update the crate on crates.io? |
I have the permissions to do that, so no worries. |
That's good to hear because it would be really bad for this amazing crate! |
This should be fixed in the 0.14.0 release. Please reopen if issues persist. |
Is there any chance of a 0.13.x (semver-compatible) release with the fix? This bug breaks e.g. https://crates.io/crates/async-local-bounded-channel, and with rust-lang/rust#71274 the silent UB will turn into a loud panic. |
mem::uninitialized
is deprecated because it's basically impossible to use correctly:From
mem::uninitialized
's docs:The text was updated successfully, but these errors were encountered: