Omit LAST_MODIFIED static header in templates when optimized is true

[mark-vieira]

When using the optimized option in the Rocker compiler the hot reloading feature is disabled. Since the LAST_MODIFIED field in the compiled templates is only used for this purpose it should be omitted when this option is used. The use case here is that we want to cache these compiled templates and reuse the outputs in conjunction with Gradle build cache. Having different outputs for the same inputs breaks this capability. Currently we are manually stripping these fields out.

[jjlauer]

Hey Mark, Sounds reasonable to me. Would you be interested in helping make that modification and submitting a PR?

…

-Joe

On Tue, Apr 4, 2017 at 2:18 PM, Mark Vieira ***@***.***> wrote: When using the optimized option in the Rocker compiler the hot reloading feature is disabled. Since the LAST_MODIFIED field in the compiled templates is only used for this purpose it should be omitted when this option is used. The use case here is that we want to cache these compiled templates and reuse the outputs in conjunction with Gradle build cache <https://docs.gradle.org/release-candidate/userguide/build_cache.html>. Having different outputs for the same inputs breaks this capability. Currently we are manually stripping these fields out. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjwAsLdl8mRPBXttwvSSCj4YZWAGaD_ks5rsomRgaJpZM4MzPOQ> .

[jjlauer]

@mark-vieira Took a look at what you suggested and I have a couple questions. First, the field LAST_MODIFIED doesn't exist -- did you mean MODIFIED_AT ? Second, that value is the "last modified" value from the source file itself. I guess my question is -- do you see that value change on your system if you didn't actually the underlying source file?

[mark-vieira]

First, the field LAST_MODIFIED doesn't exist -- did you mean MODIFIED_AT

Doh, yes :)

I guess my question is -- do you see that value change on your system if you didn't actually the underlying source file?

Not for local development, but this value changes when doing things like fresh checkouts. So two CI builds using the same source will have different compiled output.

[mark-vieira]

I've gone ahead and submitted pull request #58 to address this.

[jjlauer]

@mark-vieira Excellent work. Pushed out v0.18.0 to maven central with your changes.

[etiennestuder]

Awesome to have this released so quickly!