Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating dependency versions in requests.txt #77

Closed
tombohub opened this issue Dec 10, 2023 · 8 comments
Closed

updating dependency versions in requests.txt #77

tombohub opened this issue Dec 10, 2023 · 8 comments

Comments

@tombohub
Copy link
Contributor

tombohub commented Dec 10, 2023

Hi, it seems lot of dependencies are older versions in requests.txt. Because all of them are pinned to exact version number we cannot install pinkfish using poetry, unless we downgrade packages installed before we installed pinkfish.

Error message poetry:

Because no versions of pinkfish match >1.16.0,<2.0.0
 and pinkfish (1.16.0) depends on requests (2.28.1), pinkfish (>=1.16.0,<2.0.0) requires requests (2.28.1).
So, because stock-analytics depends on both requests (^2.31.0) and pinkfish (^1.16.0), version solving failed.

which means I get requests v2.31.0 installed , but pinkfish requires exact 2.28.1 version.

How do we go with updating dependencies to at lease using carrots: ^2.28.1 ?

@fja05680
Copy link
Owner

fja05680 commented Dec 11, 2023 via email

@fja05680
Copy link
Owner

fja05680 commented Dec 11, 2023 via email

@tombohub
Copy link
Contributor Author

Hi, yes I use pinfish in venv. The thing is I use it as a part of my bigger application which also uses pandas, requests, seaborn on it's own. There comes the dependency conflict.

@fja05680
Copy link
Owner

fja05680 commented Dec 11, 2023 via email

@fja05680
Copy link
Owner

fja05680 commented Dec 29, 2023

Hi,
I updated everything to newer versions and removed dependency to TA-Lib. I'll plan to do a new release in a couple of days. I closed your PR. I did incorporate your suggestion to .gitignore. I didn't change setup.py though because TA-Lib is no longer called out in requirements.txt.

@fja05680
Copy link
Owner

fja05680 commented Dec 29, 2023

Release 2.1.0 created. I looked at requirements.txt and there are is no longer a reference to talib or TA-Lib. Also v2.31.0 is called out for requests. I hope this solved the issue you were having. Please let me know.

@tombohub
Copy link
Contributor Author

Hi, thank you. I was able to install without problems.

@fja05680
Copy link
Owner

fja05680 commented Dec 31, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants