Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPC-127 Dataset type badge #49

Merged
merged 1 commit into from
May 19, 2023
Merged

SPC-127 Dataset type badge #49

merged 1 commit into from
May 19, 2023

Conversation

jonathansberry
Copy link
Member

Description

Bob from Avenir has directly requested this little UX update so that the type of the dataset is clearly visible when browsing a list of datasets.

Dependency Changes (delete if not applicable)

List any dependencies that have been removed/added/changed in this pull request and explain why.
Has the pipfile.lock or yarn.lock been updated?
If dependency management for this project is centralised, e.g. adx_deploy for ADR, please link to the coordinated PR in the project repo.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

@jonathansberry jonathansberry merged commit c1a0790 into master May 19, 2023
2 checks passed
@jonathansberry jonathansberry deleted the SPC-127-dataset-type branch May 19, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant