Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPC-130 SPC-131 Search users by ID #50

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Conversation

jonathansberry
Copy link
Member

@jonathansberry jonathansberry commented Jul 31, 2023

Description

Bob wants the users page added to the main nav, and to be able to search users by ID

Testing

I have just included tests for the new chain user_list action. Adding a link to the main nav is a small frontend change ans so not something we usually test.

Documentation

The Spectrum CKAN API docs have been updated accordingly:
https://documenter.getpostman.com/view/15920939/UzBpK5q9#7df82cae-1477-43a9-a2aa-769e3ed0f5b1

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • [*] The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • [*] I have developed these changes in discussion with the appropriate project manager.
  • [*] My code follows the general Fjelltopp documentation (see Confluence).
  • [*] I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • [*] I have rebased this branch with master.
  • [*] New dependency changes have been committed.
  • [*] I have added automated tests that prove my fix is effective or that my feature works.
  • [*] New and existing tests pass locally with my changes.
  • [*] My changes generate no new warnings.
  • [*] I have performed a self-review of my own code.
  • [*] I have assigned at least one reviewer.

@jonathansberry jonathansberry marked this pull request as draft July 31, 2023 11:36
@jonathansberry jonathansberry marked this pull request as ready for review July 31, 2023 11:50
@jonathansberry jonathansberry merged commit b0b41c6 into master Jul 31, 2023
2 checks passed
@jonathansberry jonathansberry deleted the SPC-130-SPC-131-users branch July 31, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants