-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adx 977 invalid filename allowed upon upload #277
Adx 977 invalid filename allowed upon upload #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can fully replace your url_encode
implementation with the use of Python urllib quote function (still wrapped in form of template helper of course).
Also please add a regression test for the bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the linting (flake8) issues in the code.
Description
Having a % in the filename causes a 400 bad request.
What I did: wrote an helper to encode the filename in the CKAN template
Added a short javascript code in the template to update the filename upon DomContentLoaded
Checklist
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request).You may not need to check all boxes.