Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

管理者ではないメンターのテストユーザーを追加 #3602

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

ShotaTsuru
Copy link
Contributor

@ShotaTsuru ShotaTsuru commented Nov 20, 2021

What

管理者では無いメンターのテストユーザーを追加

管理者ではないメンターのテストユーザーがほしい · Issue #3575 · fjordllc/bootcamp

@ShotaTsuru
Copy link
Contributor Author

@mami-inuzuka
お手隙の時にレビューお願い致します🙇‍♂️

name: Una Admen
name_kana: ウナ アドメン
twitter_account: unadmentor
facebook_url:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShotaTsuru facebook_urlとblog_urlは設定しない場合値を空にする、で大丈夫ですか?💡
(他にこれらの値が設定されていないユーザーがいなかったため念のため確認です😊🙏)

Copy link
Contributor Author

@ShotaTsuru ShotaTsuru Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mami-inuzuka
はい!空にしているのは意図的にしておりました!🙇‍♂️
こちらはLGTMという認識で大丈夫でしょうか??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShotaTsuru あ🙇🏻‍♂️こちらは私の知識不足で確認させていただいた次第なのですが、値を指定しない場合空にするので文法的に問題がないのであれば大丈夫です!🙆‍♀️(それで問題なければLGTMでお願いします👍)

@mami-inuzuka
Copy link
Contributor

@ShotaTsuru
お疲れ様です!一件だけコメントさせていただきました。ご確認よろしくお願いします😊🙏

@ShotaTsuru ShotaTsuru force-pushed the feature/add_a_mentor_non-administrative_user branch from 9ef1a09 to 5ef8aec Compare November 24, 2021 11:15
@ShotaTsuru
Copy link
Contributor Author

@komagata
お手数ですがレビューお願い致します!🙇‍♂️

Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflictの修正お願いします〜

@ShotaTsuru ShotaTsuru force-pushed the feature/add_a_mentor_non-administrative_user branch from 5ef8aec to 839ba5c Compare December 1, 2021 12:14
@ShotaTsuru
Copy link
Contributor Author

ShotaTsuru commented Dec 1, 2021

@komagata
こちらのコメントに今さっき気がつきました申し訳ありません!!
直ちにコンフリクト修正いたしました。

Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました、OKですー🙆‍♂️

@komagata komagata merged commit ddcf5bb into main Dec 3, 2021
@komagata komagata deleted the feature/add_a_mentor_non-administrative_user branch December 3, 2021 10:24
@github-actions github-actions bot mentioned this pull request Dec 3, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants