検索結果一覧でWIPの日報やDocsを識別できるようにした #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clio209 |
clio209
reviewed
Mar 29, 2022
eatplaynap
force-pushed
the
feature/identify-wip-from-search-results
branch
from
a96529c
to
da3ad52
Compare
cafedomancer
reviewed
Apr 1, 2022
clio209
approved these changes
Apr 3, 2022
There was a problem hiding this comment.
@eatplaynap さん
issue取り組みお疲れ様です。再度取り込み、挙動を確認しました。
また、if文のリファクタリング、有難うございます。非常に読みやすくなりました！all等は深い意味はなく、何かそうしないといけない理由を考えたまでで、混乱させて申し訳ないです。。🙇♂️
自分の方はapproveいたします〜。
|
@clio209 @cafedomancer |
cafedomancer
reviewed
Apr 6, 2022
eatplaynap
force-pushed
the
feature/identify-wip-from-search-results
branch
from
60e9788
to
db40874
Compare
|
@cafedomancer |
|
@cafedomancer 丁寧なレビューありがとうございました！勉強になりました〜！ |
komagata
requested changes
Apr 8, 2022
Comment on lines
8
to
10
| if searchable.respond_to?(:wip?) | ||
| json.wip searchable.wip? | ||
| end |
There was a problem hiding this comment.
APIとしてはwipがfalseの場合も知りたいと思うので、項目自体を表示しないのではなく、falseを出すのがいいと思います〜
|
@komagata |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue概要
検索結果一覧では、見た目上WIPとそうでないものとの区別がつかないため、WIPであることを見て分かるように修正しました。
変更前
WIPとWIPでないものが混在しているが、どれがWIPか分からない
変更後
WIPのものがひと目でわかるようになった
確認手順
feature/identify-wip-from-search-resultsを手元に取り込むbin/rails setup実行bin/rails sでサーバーを立ち上げる