トップページのRubyKaigi2022横断幕バナーを削除 #5812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mayumonj 確認ありがとうございます！消し忘れの方も削除お願いしたいですー🙏 |
|
@shucream-p |
shucream-p
approved these changes
Nov 21, 2022
|
@shucream-p ありがとうございますー！🙌✨ |
|
@komagata |
komagata
deleted the
feature/remove-RubyKaigi2022-banner-from-top-page
branch
18 tasks
|
レビューありがとうございました！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
RubyKaigi2022は終了しているため、トップページのRubyKaigi2022横断幕バナーを削除しました。
あわせて、削除されていなかったRubyKaigi2021のバナー画像も削除しました。
...
変更確認方法
feature/remove-RubyKaigi2022-banner-from-top-pageをローカルに取り込むbin/rails sでローカル環境を立ち上げる変更前
変更後
確認したいこと
app/assets/images/banners/ima1zumi.svg）も残っているのですが、あわせて削除したほうがよいでしょうか？