Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQにカテゴリを追加する #7093

Open
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

sochi419
Copy link
Contributor

@sochi419 sochi419 commented Dec 1, 2023

Issue

概要

こちらのPRでyumaさんがFAQのCRUD機能を実装した。今回のPRで、yumaさんが実装したFAQのCRUD機能にカテゴリ機能を追加した。
以下の実装を行った。

変更確認方法

  1. feature/add-category-for-faqsをローカルに取り込む
  2. rails db:setupを実行する
  3. http://localhost:3000/faqにアクセス
  4. カテゴリタブを選択して、カテゴリ毎に表示が切り替わることを確認する。(カテゴリタブは下記画像の赤で囲った箇所です。デザインが入ったら画像を差し替える予定です。)
image
  1. http://localhost:3000/admin/faqs/newにアクセス
  2. 「質問」「回答」に任意な文字を入力する。カテゴリーは任意のカテゴリーを選択する。その後「登録する」ボタンを選択する。
  3. http://localhost:3000/admin/faqsにアクセス
  4. 下にスクロールして6.で作成したFAQが表示されていることを確認する。表示されているカテゴリと、6.で選択したカテゴリが一致していることを確認する。

Screenshot

変更前

image image

変更後

  • http://localhost:3000/faq
    ※ 画像はカテゴリタブのデザインがまだ入っていない状態なので、デザインが入ったら画像を差し替えます。
image image

@sochi419 sochi419 force-pushed the feature/add-faq-features-in-admin-page branch from a7ff054 to 1e14fcb Compare December 5, 2023 06:21
@sochi419 sochi419 self-assigned this Dec 5, 2023
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch from 2dd7cdc to 1431811 Compare December 5, 2023 06:22
@sochi419 sochi419 force-pushed the feature/add-faq-features-in-admin-page branch from 1e14fcb to 1d0a287 Compare December 12, 2023 02:24
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch from 1431811 to d90e8da Compare December 12, 2023 02:25
@sochi419 sochi419 force-pushed the feature/add-faq-features-in-admin-page branch from 1d0a287 to 7b512f1 Compare January 9, 2024 00:21
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch from d90e8da to dbf6199 Compare January 9, 2024 00:23
@sochi419 sochi419 force-pushed the feature/add-faq-features-in-admin-page branch from 7b512f1 to 5d6b16c Compare January 17, 2024 01:52
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch from dbf6199 to 5417a94 Compare January 17, 2024 01:52
@sochi419 sochi419 force-pushed the feature/add-faq-features-in-admin-page branch from 5d6b16c to c686c50 Compare February 4, 2024 14:41
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch from 5417a94 to 33b2edd Compare February 4, 2024 14:42
@sochi419 sochi419 force-pushed the feature/add-faq-features-in-admin-page branch from c686c50 to 9d0c3a1 Compare February 6, 2024 05:44
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch 4 times, most recently from 1793342 to 19b3170 Compare February 12, 2024 04:50
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch 2 times, most recently from a08f4e1 to 9c629fa Compare February 27, 2024 01:59
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch 3 times, most recently from b75b91a to 6772716 Compare March 4, 2024 08:13
@sochi419 sochi419 changed the base branch from feature/add-faq-features-in-admin-page to main March 5, 2024 02:18
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch from b5ad47e to 17e975e Compare March 5, 2024 11:41
@sochi419 sochi419 marked this pull request as ready for review March 5, 2024 15:00
@sochi419
Copy link
Contributor Author

sochi419 commented Mar 5, 2024

@omochiumaiumai
お疲れ様です!
こちらのPRのレビューをお願いさせていただきたくてご連絡させていただきました🙏

ご対応可能なようでしたら、お手すきの際にでもご確認いただけますと幸いです。
よろしくお願いいたします。

@omochiumaiumai
Copy link
Contributor

@sochi419
お疲れ様です!
申し訳ありませんが少々立て込んでおりレビューをするのに十分な時間が確保できないため、他の方にお願いしていただけるとありがたいです🙇‍♂お役に立てずすみません😭

@sochi419
Copy link
Contributor Author

sochi419 commented Mar 7, 2024

@omochiumaiumai
連絡ありがとうございます!
承知しました!

@sochi419 sochi419 removed the request for review from omochiumaiumai March 7, 2024 00:43
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch from 17e975e to a879736 Compare March 26, 2024 05:04
@sochi419 sochi419 force-pushed the feature/add-category-for-faqs branch from 1b5618d to d20ec5e Compare April 26, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants