markdown-it-anchor の slugify が十分使えそうなので @sindresorhus/slugify の代わりにデフォルトのものを使うようにする #7860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
Markdown 中のアンカーリンクが重複する問題を部分的に解決します。具体的には、アンカーリンクの slug 化に使っているライブラリを別のものに置き換えます。詳細は #4607 (comment)
変更確認方法
use-default-slugify-instead-of-sindresorhus-slugifyをローカルに取り込むScreenshot
変更前
(h2 の id 属性が空だったり
-1だったり、a の href 属性も#だったり#-1だったり)変更後
(h2 の id 属性が見出しのテキストを URL エスケープしたもの、a の href 属性も同様)
