Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dublication in input.dobs.read_dobs #110

Closed
fjosw opened this issue Jun 15, 2022 · 1 comment · Fixed by #112
Closed

Dublication in input.dobs.read_dobs #110

fjosw opened this issue Jun 15, 2022 · 1 comment · Fixed by #112
Assignees
Labels
bug Something isn't working

Comments

@fjosw
Copy link
Owner

fjosw commented Jun 15, 2022

In the function read_dobs content is updated twice, once within and once after the if clause. I think lines 590 & 591 in https://github.com/fjosw/pyerrors/blob/develop/pyerrors/input/dobs.py should be removed as it is not possible to read an unzipped xml in the current version.

@fjosw fjosw added the bug Something isn't working label Jun 15, 2022
@s-kuberski
Copy link
Collaborator

Thanks for looking into these routines, I'll correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants