Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug coming from difference in search methods in sfcf inputs #163

Closed
jkuhl-uni opened this issue Mar 14, 2023 · 2 comments · Fixed by #164
Closed

Bug coming from difference in search methods in sfcf inputs #163

jkuhl-uni opened this issue Mar 14, 2023 · 2 comments · Fixed by #164
Labels
bug Something isn't working

Comments

@jkuhl-uni
Copy link
Collaborator

Hi,
I found a bug in the inputs, when one reads reweighting factors from openQCD and data from sfcf, it can happen, that the data is correctly sorted by replika in the openQCD ones, but not the sfcf read method, as I haven't implemented it in PR #153
Just wanted to make you aware of this, I'll try to fix it later this week, as I am currently working on refactoring the sfcf read method anyways.

@fjosw
Copy link
Owner

fjosw commented Mar 14, 2023

Thanks for taking care of this. Was this bug introduced in #153 or was it there already in previous releases?

@fjosw fjosw added the bug Something isn't working label Mar 14, 2023
@fjosw fjosw changed the title Bug coming from difference in search methods in inputs Bug coming from difference in search methods in sfcf inputs Mar 14, 2023
@jkuhl-uni
Copy link
Collaborator Author

I think this appears due to the inconsistencies between the sorting by replika of openQCD observables introduced in PR #153 such that previous versions sorted them in the same way, just that in these cases it could happen that a replika label got mixed up in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants