Impr/refactor find files #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jkuhl-uni thanks for the fix. There seem to be conflicts between this PR and the develop branch. Can you please resolve them so that I can review the changes? |
This was referenced Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some small issues by one user, if one only specifies very few characters as the prefix in the input methods, I built a better sorting algorithm for the files and replica names.
While working on this, I also found a minor bug, where the files of the replica themselves, but not the replica names would be sorted in one of the routines.
A small test for this is also submitted.
Please feel free to comment if this does not seem to work correctly or I forgot any edge-cases.
The ultimate fallback for this is still the same sorting used in earlier versions of the methods.