New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: _standard_fit method made redundant. #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes. I spotted a bug that is not caught by the tests.
Thanks! The two functions |
I would say that |
I agree. We can keep this in mind for the future. |
Maybe it would be a good idea to add a warning then, along the lines of 'For correlated data points the residuals are not necessarily expected to be ~N(0,1)'? Apart from that I also think it looks good now, thanks. |
I started refactoring the fit code and removed the
_standard_fit
function by merging its functionality with_combined_fit
. All tests pass so it looks like nothing went wrong in the process but please have a close look @s-kuberski & @PiaLJP .