Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added __slots__ to Corr class. #155

Merged
merged 1 commit into from
Feb 27, 2023
Merged

feat: added __slots__ to Corr class. #155

merged 1 commit into from
Feb 27, 2023

Conversation

fjosw
Copy link
Owner

@fjosw fjosw commented Feb 24, 2023

This PR adds the __slots__ class attribute to the Corr class which should result in a few percent memory saving per Corr instance.

s-kuberski
s-kuberski approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@s-kuberski s-kuberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fjosw fjosw merged commit a33c0a2 into develop Feb 27, 2023
@fjosw fjosw deleted the feat/corr_slots branch February 27, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-kuberski s-kuberski s-kuberski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fjosw @s-kuberski