Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_calculate_drho for large time separations #157

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Conversation

fjosw
Copy link
Owner

@fjosw fjosw commented Feb 26, 2023

This PR fixes _compute_drho for i>w_max // 2 and closes #156. Irrespective of this we should maybe think about how the gamma_method should deal with observables that have values like nan and inf.

@s-kuberski
Copy link
Collaborator

Great, thanks! This seems to resolve the first issue.

In principle we could skip the whole procedure if the mean value is nan or inf.

The second issue in #156 is not yet resolved. I think the point is that we only want to go up to w_max // gapsize in the loop, because we use the indexing [gapsize::gapsize] here. This issue shows up for the nan obs, because the loop does not end before the last index is reached.
Would you like to add this in your pr?

- Test added

Co-authored-by: Simon Kuberski <simon.kuberski@uni-muenster.de>
@fjosw
Copy link
Owner Author

fjosw commented Feb 27, 2023

Thanks for spotting this I think the last commit should cover this case. I also added your example to the tests.

Copy link
Collaborator

@s-kuberski s-kuberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks!

@fjosw fjosw merged commit de35332 into develop Feb 28, 2023
@fjosw fjosw deleted the fix/calc_rho_large_t branch February 28, 2023 15:46
@s-kuberski s-kuberski mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gamma_method() is broken for Obs that are NaN
2 participants