Feat/files idl xsf #185
Merged
Feat/files idl xsf #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjosw
pushed a commit
that referenced
this pull request
Jun 1, 2023
* added kwrg idl to ms5_xsf_read * change output, warn user if expected idl not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made small changes to the xsf read method. Like this, the user can specify a range of idls that are to be read from each replikum file. This could be useful e.g. for crosschecks with other methods.
If the "expected" (meaning user-given) idls are not found in a file, a warning is thrown.
I also added another test for this case.