forked from kiegroup/jbpm
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[kie-roadmap-119] Scheduled jobs do not keep configured execution time (
kiegroup#2292) * [kie-roadmap-119] Scheduled jobs do not keep configured execution time * [kie-roadmap-119] Make sure job gets rescheduled even if execution time exceeds nextRun value
- Loading branch information
1 parent
d9bde80
commit f32c104
Showing
5 changed files
with
344 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
225 changes: 225 additions & 0 deletions
225
jbpm-services/jbpm-executor/src/test/java/org/jbpm/executor/LogCleanupCommandTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,225 @@ | ||
| /* | ||
| * Copyright 2023 Red Hat, Inc. and/or its affiliates. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.jbpm.executor; | ||
|
|
||
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import java.util.UUID; | ||
|
|
||
| import javax.persistence.EntityManagerFactory; | ||
| import javax.persistence.Persistence; | ||
|
|
||
| import org.jboss.byteman.contrib.bmunit.BMScript; | ||
| import org.jboss.byteman.contrib.bmunit.BMUnitConfig; | ||
| import org.jboss.byteman.contrib.bmunit.BMUnitRunner; | ||
| import org.jbpm.executor.impl.ExecutorServiceImpl; | ||
| import org.jbpm.executor.test.CountDownAsyncJobListener; | ||
| import org.jbpm.test.util.ExecutorTestUtil; | ||
|
|
||
| import org.junit.After; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
|
|
||
| import org.kie.api.executor.CommandContext; | ||
| import org.kie.api.executor.ExecutorService; | ||
| import org.kie.api.executor.RequestInfo; | ||
| import org.kie.api.executor.STATUS; | ||
| import org.kie.api.runtime.query.QueryContext; | ||
| import org.kie.test.util.db.PoolingDataSourceWrapper; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| @RunWith(BMUnitRunner.class) | ||
| @BMUnitConfig(loadDirectory = "target/test-classes") | ||
| public class LogCleanupCommandTest { | ||
|
|
||
| private PoolingDataSourceWrapper pds; | ||
|
|
||
| protected ExecutorService executorService; | ||
| protected EntityManagerFactory emf = null; | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| pds = ExecutorTestUtil.setupPoolingDataSource(); | ||
| emf = Persistence.createEntityManagerFactory("org.jbpm.executor"); | ||
|
|
||
| executorService = ExecutorServiceFactory.newExecutorService(emf); | ||
|
|
||
| executorService.init(); | ||
| executorService.setThreadPoolSize(1); | ||
| executorService.setInterval(3); | ||
| } | ||
|
|
||
| @After | ||
| public void tearDown() { | ||
| executorService.clearAllErrors(); | ||
| executorService.clearAllRequests(); | ||
|
|
||
| executorService.destroy(); | ||
| if (emf != null) { | ||
| emf.close(); | ||
| } | ||
| pds.close(); | ||
| } | ||
|
|
||
| protected CountDownAsyncJobListener configureListener(int threads) { | ||
| CountDownAsyncJobListener countDownListener = new CountDownAsyncJobListener(threads); | ||
| ((ExecutorServiceImpl) executorService).addAsyncJobListener(countDownListener); | ||
|
|
||
| return countDownListener; | ||
| } | ||
|
|
||
|
|
||
| @Test(timeout=10000) | ||
| @BMScript(value = "byteman-scripts/simulateSlowLogCleanupCommand.btm") | ||
| public void logCleanupSingleRunTest() throws InterruptedException { | ||
| CountDownAsyncJobListener countDownListener = configureListener(1); | ||
|
|
||
| CommandContext ctxCMD = new CommandContext(); | ||
| ctxCMD.setData("businessKey", UUID.randomUUID().toString()); | ||
| ctxCMD.setData("SingleRun", "true"); | ||
| ctxCMD.setData("EmfName", "org.jbpm.executor"); | ||
| ctxCMD.setData("SkipProcessLog", "true"); | ||
| ctxCMD.setData("SkipTaskLog", "true"); | ||
| executorService.scheduleRequest("org.jbpm.executor.commands.LogCleanupCommand", ctxCMD); | ||
|
|
||
| countDownListener.waitTillCompleted(); | ||
|
|
||
| List<RequestInfo> rescheduled = executorService.getRequestsByBusinessKey((String)ctxCMD.getData("businessKey"), Arrays.asList(STATUS.QUEUED), new QueryContext()); | ||
| assertEquals(0, rescheduled.size()); | ||
|
|
||
| List<RequestInfo> inErrorRequests = executorService.getInErrorRequests(new QueryContext()); | ||
| assertEquals(0, inErrorRequests.size()); | ||
| List<RequestInfo> queuedRequests = executorService.getQueuedRequests(new QueryContext()); | ||
| assertEquals(0, queuedRequests.size()); | ||
| List<RequestInfo> executedRequests = executorService.getCompletedRequests(new QueryContext()); | ||
| assertEquals(1, executedRequests.size()); | ||
| } | ||
|
|
||
| @Test(timeout=10000) | ||
| @BMScript(value = "byteman-scripts/simulateSlowLogCleanupCommand.btm") | ||
| public void logCleanupNextRunIntervalTest() throws InterruptedException { | ||
| CountDownAsyncJobListener countDownListener = configureListener(1); | ||
|
|
||
| CommandContext ctxCMD = new CommandContext(); | ||
| ctxCMD.setData("businessKey", UUID.randomUUID().toString()); | ||
| ctxCMD.setData("NextRun", "10s"); | ||
| ctxCMD.setData("EmfName", "org.jbpm.executor"); | ||
| ctxCMD.setData("SkipProcessLog", "true"); | ||
| ctxCMD.setData("SkipTaskLog", "true"); | ||
| executorService.scheduleRequest("org.jbpm.executor.commands.LogCleanupCommand", ctxCMD); | ||
|
|
||
| countDownListener.waitTillCompleted(); | ||
|
|
||
| List<RequestInfo> rescheduled = executorService.getRequestsByBusinessKey((String)ctxCMD.getData("businessKey"), Arrays.asList(STATUS.QUEUED), new QueryContext()); | ||
| assertEquals(1, rescheduled.size()); | ||
|
|
||
| List<RequestInfo> inErrorRequests = executorService.getInErrorRequests(new QueryContext()); | ||
| assertEquals(0, inErrorRequests.size()); | ||
| List<RequestInfo> queuedRequests = executorService.getQueuedRequests(new QueryContext()); | ||
| assertEquals(1, queuedRequests.size()); | ||
| List<RequestInfo> executedRequests = executorService.getCompletedRequests(new QueryContext()); | ||
| assertEquals(1, executedRequests.size()); | ||
|
|
||
| executorService.cancelRequest(queuedRequests.get(0).getId()); | ||
|
|
||
| long firstExecution = executedRequests.get(0).getTime().getTime(); | ||
| long nextExecution = queuedRequests.get(0).getTime().getTime(); | ||
|
|
||
| // time difference between first and second should be at least 11 seconds (10s next interval + artificial slowdown from byteman) | ||
| long diff = nextExecution - firstExecution; | ||
| assertTrue(diff > 11000); | ||
| } | ||
|
|
||
| @Test(timeout=10000) | ||
| @BMScript(value = "byteman-scripts/simulateSlowLogCleanupCommand.btm") | ||
| public void logCleanupNextRunFixedTest() throws InterruptedException { | ||
| CountDownAsyncJobListener countDownListener = configureListener(1); | ||
|
|
||
| CommandContext ctxCMD = new CommandContext(); | ||
| ctxCMD.setData("businessKey", UUID.randomUUID().toString()); | ||
| ctxCMD.setData("NextRun", "10s"); | ||
| ctxCMD.setData("EmfName", "org.jbpm.executor"); | ||
| ctxCMD.setData("SkipProcessLog", "true"); | ||
| ctxCMD.setData("SkipTaskLog", "true"); | ||
| ctxCMD.setData("RepeatMode", "fixed"); | ||
| executorService.scheduleRequest("org.jbpm.executor.commands.LogCleanupCommand", ctxCMD); | ||
|
|
||
| countDownListener.waitTillCompleted(); | ||
|
|
||
| List<RequestInfo> rescheduled = executorService.getRequestsByBusinessKey((String)ctxCMD.getData("businessKey"), Arrays.asList(STATUS.QUEUED), new QueryContext()); | ||
| assertEquals(1, rescheduled.size()); | ||
|
|
||
| List<RequestInfo> inErrorRequests = executorService.getInErrorRequests(new QueryContext()); | ||
| assertEquals(0, inErrorRequests.size()); | ||
| List<RequestInfo> queuedRequests = executorService.getQueuedRequests(new QueryContext()); | ||
| assertEquals(1, queuedRequests.size()); | ||
| List<RequestInfo> executedRequests = executorService.getCompletedRequests(new QueryContext()); | ||
| assertEquals(1, executedRequests.size()); | ||
|
|
||
| executorService.cancelRequest(queuedRequests.get(0).getId()); | ||
|
|
||
| long firstExecution = executedRequests.get(0).getTime().getTime(); | ||
| long nextExecution = queuedRequests.get(0).getTime().getTime(); | ||
|
|
||
| // time difference between first and second should be less than 11 seconds (10s next interval, regardless of artifial slowdown by byteman) | ||
| long diff = nextExecution - firstExecution; | ||
| assertTrue(diff < 11000); | ||
| } | ||
|
|
||
| @Test(timeout=10000) | ||
| @BMScript(value = "byteman-scripts/simulateSlowLogCleanupCommand.btm") | ||
| public void logCleanupNextRunFixedIntervalTooSmallTest() throws InterruptedException { | ||
| CountDownAsyncJobListener countDownListener = configureListener(1); | ||
| // this delay will be invoked 3 times during the test, resulting in an overall delay of 2s | ||
| System.setProperty("byteman.jpaaudit.sleep", "666"); | ||
|
|
||
| CommandContext ctxCMD = new CommandContext(); | ||
| ctxCMD.setData("businessKey", UUID.randomUUID().toString()); | ||
| ctxCMD.setData("NextRun", "1s"); | ||
| ctxCMD.setData("EmfName", "org.jbpm.executor"); | ||
| ctxCMD.setData("SkipProcessLog", "true"); | ||
| ctxCMD.setData("SkipTaskLog", "true"); | ||
| ctxCMD.setData("RepeatMode", "fixed"); | ||
| executorService.scheduleRequest("org.jbpm.executor.commands.LogCleanupCommand", ctxCMD); | ||
|
|
||
| countDownListener.waitTillCompleted(); | ||
|
|
||
| List<RequestInfo> rescheduled = executorService.getRequestsByBusinessKey((String)ctxCMD.getData("businessKey"), Arrays.asList(STATUS.QUEUED), new QueryContext()); | ||
| // check if the job has been rescheduled | ||
| assertEquals(1, rescheduled.size()); | ||
|
|
||
| List<RequestInfo> inErrorRequests = executorService.getInErrorRequests(new QueryContext()); | ||
| assertEquals(0, inErrorRequests.size()); | ||
| List<RequestInfo> queuedRequests = executorService.getQueuedRequests(new QueryContext()); | ||
| assertEquals(1, queuedRequests.size()); | ||
| List<RequestInfo> executedRequests = executorService.getCompletedRequests(new QueryContext()); | ||
| assertEquals(1, executedRequests.size()); | ||
|
|
||
| executorService.cancelRequest(queuedRequests.get(0).getId()); | ||
|
|
||
| long firstExecution = executedRequests.get(0).getTime().getTime(); | ||
| long nextExecution = queuedRequests.get(0).getTime().getTime(); | ||
|
|
||
| // time difference between first and second should be around 2 seconds (2nd job rescheduled immediately) | ||
| long diff = nextExecution - firstExecution; | ||
| assertTrue(diff >= 2000 && diff < 3000); | ||
| System.clearProperty("byteman.jpaaudit.sleep"); | ||
| } | ||
| } |
Oops, something went wrong.