Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using pkgconfig-depends when possible #160

Closed
WeetHet opened this issue May 24, 2022 · 3 comments
Closed

Consider using pkgconfig-depends when possible #160

WeetHet opened this issue May 24, 2022 · 3 comments
Labels
enhancement Improvements to an existing feature

Comments

@WeetHet
Copy link

WeetHet commented May 24, 2022

On systems where GLEW is not present in default folders (/usr/lib, etc), extra-libraries cannot find it, so you should better consider using pkgconfig-depends: glew, when pkg-config is present in system path

@fjvallarino
Copy link
Owner

Do you have an example of how that would work? It can be a link to another project. I mainly wonder if a pkg-config flag exists that can be checked.

@fjvallarino fjvallarino added the enhancement Improvements to an existing feature label May 28, 2022
@WeetHet
Copy link
Author

WeetHet commented May 29, 2022

For cabal it’s pkgconfig-depends, as described
here: https://cabal.readthedocs.io/en/3.4/cabal-package.html

I guess, there is a similar option for stack, but I don’t use it

@fjvallarino
Copy link
Owner

A PR for using pkg-config when available has just been merged. I tested on macOS and Linux and all seems to work fine but, since I have not had issues linking GLEW before, I can't validate it fixes the reported issue.

There is no test for pkg-config being installed because it's one of the pre-requisites for the library (and, mainly, because I don't know if that check can be performed in .cabal files).

I'll close the issue. In case you happen to test this and find problems, don't hesitate to re-open the issue or create a new one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants