Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Composite's onChange event part of its event queue #71

Merged
merged 6 commits into from
Jan 23, 2022

Conversation

fjvallarino
Copy link
Owner

@fjvallarino fjvallarino commented Jan 23, 2022

Composite's onChange event is now sent to its handleEvent function, not to its parent; the type of the generated event was updated to reflect this change. The rationale is that since onInit is sent to handleEvent, having onChange sent to its parent was confusing. At the same time there was not an easy way in handleEvent to know when the model changed.

Widgets that want to report model changes to its parent can use Report/RequestParent; an example can be found in ColorPicker.

@fjvallarino fjvallarino merged commit 8af45ca into main Jan 23, 2022
@fjvallarino fjvallarino deleted the fix/composite-on-change branch January 23, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant