Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive uploads #25

Closed
trufanov-nok opened this issue May 7, 2016 · 8 comments
Closed

Recursive uploads #25

trufanov-nok opened this issue May 7, 2016 · 8 comments

Comments

@trufanov-nok
Copy link

Hi,
Would be great if tool will be able to upload a folder and its subfolders recursively and automatically creating remote folders.
Like cp folder_name target_folder_name copies a folder with all subfolders and files in them to a new destination.

@fkalis
Copy link
Owner

fkalis commented May 9, 2016

Thank you for your suggestion. As soon as I find the time, I will look into that.

@Tomto23
Copy link

Tomto23 commented Jun 18, 2016

That feature would be very helpful for me, too.

@diman82
Copy link

diman82 commented Jun 28, 2016

Any new regarding this one?
I think recursive upload (preserving folder structure) is crucial.

@fkalis
Copy link
Owner

fkalis commented Jun 28, 2016

I didn't have the time yet, but I think you can expect this feature to be implemented sometime in July.

fkalis added a commit that referenced this issue Aug 29, 2016
This feature is still experimental and needs more testing before it will be merged into the master.

This refs #25.
fkalis added a commit that referenced this issue Aug 30, 2016
@fkalis fkalis changed the title Uploadig folders Recursive uploads Aug 30, 2016
@fkalis
Copy link
Owner

fkalis commented Aug 30, 2016

Sorry for the delay, but finally I have found the time to start implementing this feature.

To avoid concurrency problems, the script will first traverse through the local filesystem and create the needed folder structure in OneDrive, collecting a list of pairs (destination folder ids and filenames) before starting the actual multi-threaded upload.

To minimize the number of requests for the initial folder traversal, the function resolve_folder_id must work relative to the current directory rather than evaluating the same path prefix over and over again. For now this process can take quite a while even for small structures, especially when used with the command line option -f in combination with a long path.

@trufanov-nok
Copy link
Author

Great! Will test tomorrow.

@trufanov-nok
Copy link
Author

Hi, Have finally tested it. (took several minutes to realize that functionality is still in separate branch). It works fine as expected. Thank you one more time!

@shoeper
Copy link

shoeper commented Sep 5, 2016

Am also going to test it with several 100 GiB of data on thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants