Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable clear function test of setJointAnglesSequenceFull #914

Merged
merged 1 commit into from Dec 18, 2015

Conversation

mmurooka
Copy link
Contributor

master...mmurooka:fix-seq-test#diff-96c12b5464b8f878f96c334f0a2bae8aR300 で,
joint groupを消去するようにしたところ,
setJointAnglesSequenceFullのclearのテストが通るようになりました.

@k-okada
Copy link
Contributor

k-okada commented Dec 18, 2015

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2481/
Test PASSed.

@snozawa
Copy link
Contributor

snozawa commented Dec 18, 2015

そうですね.
removeがないと,larmのjointGroupの補間器がずっとうわがいてしまうので必要だったのかな.
エラーがでてた箇所が,左腕の部位かは調べられるかな?

@mmurooka
Copy link
Contributor Author

はい,関節ごとにcheckArrayBetweenの条件をprintして調べて,
左腕の部位が条件を満たしていないことを確認していました.
(それでgroupのテストが怪しいと気付けました.)

@snozawa
Copy link
Contributor

snozawa commented Dec 18, 2015

なるほど,了解です.
@fkanehiroさん
中身確認でき,travisも通りましたので,お手すきのときに確認いただけますと幸いです.

fkanehiro added a commit that referenced this pull request Dec 18, 2015
enable clear function test of setJointAnglesSequenceFull
@fkanehiro fkanehiro merged commit bb97795 into fkanehiro:master Dec 18, 2015
@mmurooka mmurooka deleted the fix-seq-test branch December 18, 2015 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants