Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MenuProvider render prop going down the children #125

Closed
wants to merge 1 commit into from

Conversation

Vinarnt
Copy link

@Vinarnt Vinarnt commented Aug 17, 2019

The render prop of the MenuProvider was not extracted when cloning children.
Using the render prop of the MenuProvider would also add it to the children throwing an error message in the console of type:

Warning: Invalid value for prop `render` on <div> tag. Either remove it from the element, or pass a string or number value to keep it in the DOM. For details, see https://fb.me/react-attribute-behavior

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 97.444% when pulling b97c15b on Vinarnt:master into 2b5bdec on fkhadra:master.

@fkhadra
Copy link
Owner

fkhadra commented Nov 30, 2020

Hey for the v5. I've removed the MenuProvider component

@fkhadra fkhadra closed this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants