Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ie11 animation and close button #37

Closed
fkhadra opened this issue Jul 31, 2017 · 3 comments
Closed

Fix ie11 animation and close button #37

fkhadra opened this issue Jul 31, 2017 · 3 comments
Assignees
@fkhadra
Labels
bug

Comments

@fkhadra
Copy link
Owner

fkhadra commented Jul 31, 2017 •
edited

  • Entrance and exit animation are buggy on ie11.
  • The close button is not well positioned when there is a progress bar
@fkhadra fkhadra added the bug label Jul 31, 2017
@fkhadra fkhadra self-assigned this Jul 31, 2017
@der-lukas
Copy link

Thanks for the great library! Any news on fixing this issue?

@fkhadra
Copy link
Owner Author

fkhadra commented Sep 11, 2017

Hey @der-lukas,

Thank you, appreciate! I'll focus on it this week.

@fkhadra fkhadra changed the title Fix ie11 animation Fix ie11 animation and close button Sep 11, 2017
fkhadra added a commit that referenced this issue Sep 15, 2017
@fkhadra
Fix issue with ie11 flexbox
03dc885 
When the progress bar is displayed(use absolute position) the close button is not well positioned.
Append only with ie11. Set flex to 1 for the toast body seems to fix the issue.
This relate to issue #37
@fkhadra fkhadra mentioned this issue Sep 15, 2017
Merged
@fkhadra
Copy link
Owner Author

fkhadra commented Sep 15, 2017

Yo @der-lukas ! I pushed a new version.

@fkhadra fkhadra closed this as completed Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkhadra fkhadra

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@der-lukas @fkhadra