Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 561 #563

Closed
wants to merge 6 commits into from
Closed

Fix issue 561 #563

wants to merge 6 commits into from

Conversation

achmadk
Copy link

@achmadk achmadk commented Feb 1, 2021

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test).
  5. Run yarn start to test your changes in the playground.
  6. Update the readme is needed
  7. Update the typescript definition is needed
  8. Format your code with prettier (yarn prettier-all).
  9. Make sure your code lints (yarn lint:fix).

Learn more about contributing here

use export default `ToastContainer` from '/src/components/ToastContainer.tsx' files, then recreate variable `ToastContainer` in `src/components/index.tsx` instead.

fix fkhadra#561
fix typos from 'Optionnal' to 'Optional'. add more values on `type` props

fix fkhadra#561
use export default `ToastContainer` from '/src/components/ToastContainer.tsx' files, then recreate variable `ToastContainer` in `src/components/index.tsx` instead.

fix fkhadra#561
fix typos from 'Optionnal' to 'Optional'. add more values on `type` props

fix fkhadra#561
use default import instead of `ToastContainer` to fix error testing

fix fkhadra#561
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 94.17% when pulling c80134d on achmadk:fix-issue-561 into 7ec5040 on fkhadra:master.

Copy link
Owner

@fkhadra fkhadra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @achmadk, this issue has been fixed with 7.0.3. It was caused by a missing declaration file when I published the library to npm.

@achmadk
Copy link
Author

achmadk commented Feb 1, 2021

sorry, maybe you can reject my PR.

@fkhadra
Copy link
Owner

fkhadra commented Feb 1, 2021

Np @achmadk. Thanks for trying to fix the issue, appreciate that 🙏

@fkhadra fkhadra closed this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants