Dyn sym refactor #71
Merged
Dyn sym refactor #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added portable executable support.
changed the install.sh to install more cross compilers
… files were given the name 'g++'. This might have broken the test test_cwe248.py.
… test_compiling
…licated warning output
… symbol_checking
… symbol_checking
…te and used generate_tid_map functionality. added api support to cwe caller. improved overall code quality of the caller. (removing duplicate code)
Removed the tid map generator call from the external function builder and added it as a parameter
… function Added functionality to detect binary file format (ELF/PE) in CConv Soon: - adding distinction between parameters of elf and pe binaries in Cconv
Adapted the functionality for register retrieval in the Cconv module. Reduced code redundancy.
Removed reference to example project in address_translation_test.mli
… juilet_testing
… run with a certain binary
… unittest_flexibility
…te changes in the Makefile Changed mips64 to mips64el in SConstruct
Made the compilation of test files compatible with travis Added a new script containing test files to be compiled for unit test
… extended_cconv_tests
… dyn_sym_refactor
Added a check for resolving external symbols Added unittest for symbol_utils Changed Cconv references to Symbol_utils for parse_dyn_syms
Enkelmann
requested changes
Jul 23, 2020
src/utils/symbol_utils.ml
Outdated
|
|
||
| let check_if_symbols_resolved (project : Project.t) (program : program term) (tid_map : word Tid.Map.t) : bool = | ||
| let extern = build_and_return_extern_symbols project program tid_map in | ||
| let extern = List.filter extern ~f:(fun e -> |
There was a problem hiding this comment.
Could you give the variable e a more meaningful name? When it comes to readability of code, one-letter names are almost never a good idea.
src/utils/symbol_utils.ml
Outdated
Comment on lines
238
to
240
| match Stdlib.List.mem e.name extern_symbol_blacklist with | ||
| | false -> true | ||
| | true -> false |
There was a problem hiding this comment.
Ocaml has a not operator for boolean values, you don't need to match them to invert them.
src/utils/symbol_utils.ml
Outdated
Comment on lines
246
to
253
| let not_resolved = List.filter extern ~f:(fun e -> | ||
| match Stdlib.List.mem e.tid calls with | ||
| | true -> false | ||
| | false -> true | ||
| ) in | ||
| match List.length extern = List.length not_resolved with | ||
| | true -> false | ||
| | false -> true |
src/utils/symbol_utils.mli
Outdated
Comment on lines
72
to
74
| val get_calls : Bap.Std.program Bap.Std.term -> (Bap.Std.tid * Bap.Std.tid) list | ||
|
|
||
| val check_if_symbols_resolved : Bap.Std.Project.t -> Bap.Std.program Bap.Std.term -> Bap.Std.word Bap.Std.Tid.Map.t -> bool |
There was a problem hiding this comment.
Pleas add doc comments for the two functions.
Also added doc strings to two new functions
Enkelmann
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.