Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A variable can contains digits (#35) #80

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

alexander-zubkov
Copy link
Contributor

Variables can contain digits. It may not be an elegant solution, but it works.

@fkleon
Copy link
Owner

fkleon commented Jul 16, 2023

Thanks for this! Happy to include a not-so-elegant change, if it improves things.

Two comments:

  • Noting that this change wouldn't allow a digit at the beginning of a variable, right?
  • Could you add some unit tests for various scenarios?

I've fixed the unrelated lint failure on the master branch.

@fkleon fkleon self-assigned this Jul 16, 2023
@fkleon fkleon merged commit 2c53ec8 into fkleon:master Apr 15, 2024
0 of 2 checks passed
@fkleon
Copy link
Owner

fkleon commented Apr 15, 2024

Thanks for your contribution. I've finally revisited this and added some unit tests in 0c3f79c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants