Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] [experimental] Replace webpack with parcel #330

Closed
wants to merge 2 commits into from

Conversation

mohsen1
Copy link
Contributor

@mohsen1 mohsen1 commented Jun 24, 2018

Experimental

I was playing with this repo and thought I experiment with Parcel because this project is very unique. It uses a lot of file: references in package.json and has actual dependency to Babel.

Status

Currently this is not working. Running build yields into following error message

yarn build
yarn run v1.3.2
$ rimraf ../out/* && parcel build --no-cache --out-dir=../out index.html
馃毃  /Users/mohsen/Code/astexplorer/website/src/components/SplitPane.js:74:8: Unexpected token (74:8)
  72 |       // top
  73 |       styleA = {
> 74 |         ...baseStyleVertical,
     |         ^
  75 |         top: 0,
  76 |         height: dividerPos + '%',
  77 |         paddingBottom: 3,

This is very curious because even explicitly setting Babel preset in .babelrc will not resolve this error.

/cc @DeMoorJasper and @devongovett

@DeMoorJasper
Copy link

@mohsen1
Copy link
Contributor Author

mohsen1 commented Jun 24, 2018

@DeMoorJasper that won't didn't help. object spread is part of env anyways.

@mohsen1 mohsen1 closed this Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants