Add java parser - fixes #473 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junoatwork
force-pushed
the
juno/add-java-parser
branch
from
fa7f89e
to
4d67036
Compare
fkling
reviewed
Feb 8, 2020
| }, | ||
|
|
||
| parse(parser, code) { | ||
| console.time("p"); |
There was a problem hiding this comment.
I'd prefer not to have these in here.
| console.time("p"); | ||
| const cst = parser.parse(code); | ||
|
|
||
| const clone = JSON.parse(JSON.stringify(cst)); |
|
Thanks for reviewing this! Those lines you found were not supposed to be left in there, those were debugging lines. I'll clean up this PR soon when I have a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the instructions in readme about adding a new parser- pretty painless! Please let me know if there are any changes you'd like or other review comments.