Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiply Service #3

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Multiply Service #3

merged 2 commits into from
Sep 28, 2018

Conversation

fkorotkov
Copy link
Owner

Implement Multiply as a service

First commit was created by running the following commands:

./gradlew clean
cd services
./make_a_service.sh Multiply

@fkorotkov fkorotkov merged commit 83b0255 into master Sep 28, 2018
@fkorotkov fkorotkov deleted the fedor/multiply-service branch September 28, 2018 15:44
@thomasvdvoort
Copy link

thomasvdvoort commented May 16, 2019

Hey, I was trying to generate a new service using make_a_service.sh
Unfortunately I got this response running make_a_service.sh TestService:
sed: can't read s/Example/TestService/g: No such file or directory
sed: can't read s/example/testservice/g: No such file or directory

I replaced

find $SERVICE_NAME -type f -exec sed -i '' "s/Example/$SERVICE_NAME_CAPITALIZED/g" {} +
find $SERVICE_NAME -type f -exec sed -i '' "s/example/$SERVICE_NAME/g" {} +

with

find "./$SERVICE_NAME" -type f -exec sed -i -e "s/example/$SERVICE_NAME/g" {} \;
find "./$SERVICE_NAME" -type f -exec sed -i -e "s/Example/$SERVICE_NAME_CAPITALIZED/g" {} \;

And now receive the proper results.

Great idea by having an 'Example' service, which we can modify as a 'standard base' service. For example I've added a basic Test to each service base using this concept

Thanks for making this project opensource and for your Kotlin Conf 2018 talk :)

fkorotkov added a commit that referenced this pull request May 17, 2019
@fkorotkov
Copy link
Owner Author

@thomasvdvoort Glad you liked it! Updated the script upon you suggestion. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants