#187 support compatible strings as an argument in basic_node ctors #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fktn-k
added
the
improvement
fktn-k
deleted the
feature/187_support_compatible_strings_in_node_ctor
branch
fktn-k
restored the
feature/187_support_compatible_strings_in_node_ctor
branch
fktn-k
deleted the
feature/187_support_compatible_strings_in_node_ctor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, constructing a string scalar node requires exactly the same type as basic_node::string_type as an argument type.
This restriction had been forcing users to create a lot of boilerplate codes before this PR.
To resolve the issue, this PR have supported compatible strings, e.g., character arrays or std::string_view (only with C++17 or later), as an argument of the basic_node constructor.