Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve anchor alias node management #340

Merged
merged 5 commits into from
May 12, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented May 11, 2024

This PR has improved the way of managing anchor/alias nodes by sharing the anchor node table among nodes.
The process of deserializing such nodes and have also been modified according to the above change.


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label May 11, 2024
@fktn-k fktn-k added this to the Release v0.3.7 milestone May 11, 2024
@fktn-k fktn-k self-assigned this May 11, 2024
Copy link

github-actions bot commented May 11, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit bbab1b59dc6484d775ae024415f696199e5f5138.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr340.zip
ID 1494486867
URL https://github.com/fktn-k/fkYAML/actions/runs/9049272212/artifacts/1494486867

@coveralls
Copy link

coveralls commented May 11, 2024

Pull Request Test Coverage Report for Build 9049272212

Details

  • 356 of 356 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8942798853: 0.0%
Covered Lines: 3691
Relevant Lines: 3691

💛 - Coveralls

@fktn-k fktn-k force-pushed the improve_anchor_alias_node_management branch from f75770d to bbab1b5 Compare May 12, 2024 06:00
@fktn-k fktn-k merged commit ce763cc into develop May 12, 2024
162 checks passed
@fktn-k fktn-k deleted the improve_anchor_alias_node_management branch May 12, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants