You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a reason why the Output.commit() method is implemented this way:
defcommit(self) ->None:
"""Commit the pending output state If `.attach_render` has been called, the pending frame will be submitted for display. """ifnotlib.wlr_output_test(self._ptr):
self.rollback()
raiseRuntimeError("Rendering on output failed")
ifnotlib.wlr_output_commit(self._ptr):
raiseRuntimeError("Unable to commit output")
Shouldn't the following be sufficient:
defcommit(self) ->bool:
"""Commit the pending output state If `.attach_render` has been called, the pending frame will be submitted for display. """returnlib.wlr_output_commit(self._ptr)
See the wlroot docs for the commit function:
/** * Commit the pending output state. If wlr_output_attach_render() has been * called, the pending frame will be submitted for display and a `frame` event * will be scheduled. * * On failure, the pending changes are rolled back. */boolwlr_output_commit(structwlr_output*output);
The text was updated successfully, but these errors were encountered:
Modify `Backend.start` and `Output.commit` to return boolean values
rather than checking the return value and raising an error. Move the
logic for the Pythonic APIs into the Python-specific functions, in
particular the `__enter__` and `__exit__` so these objects will be well
behaved when using the context manager.
Closes#135Closes#136
Is there a reason why the Output.commit() method is implemented this way:
Shouldn't the following be sufficient:
See the wlroot docs for the commit function:
The text was updated successfully, but these errors were encountered: