Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix issue #133: Touch class #146

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Conversation

heuer
Copy link
Contributor

@heuer heuer commented Mar 11, 2024

  • Added class Touch similar to Pointer
  • Renamed exceptions (put Event to the end)
  • Added touch.h to ffi_build.py

* Added class Touch similar to Pointer
* Renamed exceptions (put Event to the end)
* Added touch.h to ffi_build.py
@heuer
Copy link
Contributor Author

heuer commented Mar 11, 2024

@flacjacket Please review the changes, I am not familiar with CFFI yet. I don't know if these changes are sufficient to support wlr_touch.h. Please note that wlr_touch.h needs the -DWLR_USE_UNSTABLE flag.

I'll fix the ruff errors… 🙄

@heuer
Copy link
Contributor Author

heuer commented Mar 11, 2024

We have to consider whether I leave the old event names or whether we adapt the cursor.py to the new names. I would be for the latter.

Update: Updated cursor.py to use the new event names

@heuer heuer mentioned this pull request Mar 12, 2024
Copy link
Owner

@flacjacket flacjacket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@flacjacket flacjacket merged commit 644e414 into flacjacket:main Mar 14, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants