Don't wrap IdleInhibitorV1's destroy event data #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to wlroots' emitter for this signal, it *does* return the idle inhibitor's `struct wlr_surface*`. However, in practice the pointed-to data seems to be invalid, causing a crash (e.g. qtile/qtile#3361). The data does not seem to be used by any compositor so until it is needed we can probably get away without the wrapper, resolving the problem.
|
Nice catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to wlroots' emitter for this signal, it does return the idle
inhibitor's
struct wlr_surface*. However, in practice the pointed-todata seems to be invalid, causing a crash (e.g.
qtile/qtile#3361).
The data does not seem to be used by any compositor so until it is
needed we can probably get away without the wrapper, resolving the
problem.