Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 #16

Closed
dlangille opened this issue Jan 16, 2024 · 1 comment · Fixed by #17
Closed

PHP 8.3 #16

dlangille opened this issue Jan 16, 2024 · 1 comment · Fixed by #17

Comments

@dlangille
Copy link
Contributor

dlangille commented Jan 16, 2024

FYI, there are issues with PHP 8.3 - I'll post some of the errors here and I'll have a patch later.

<b>Deprecated</b>:  Creation of dynamic property RSSCreator091::$_timeout is deprecated in <b>/usr/local/share/UniversalFeedCreator/lib/Creator/FeedCreator.php</b> on line <b>238</b><br />

<b>Deprecated</b>:  Creation of dynamic property PIECreator01::$truncSize is deprecated in <b>/usr/local/share/UniversalFeedCreator/lib/Creator/PIECreator01.php</b> on line <b>29</b><br />

@dlangille
Copy link
Contributor Author

This is an untested patch. I'll submit a pull request next.

[15:20 dev-nginx01 dan /usr/local/share/UniversalFeedCreator] % diff -ruN ./lib/Creator/FeedCreator.php.orig ./lib/Creator/FeedCreator.php     
--- ./lib/Creator/FeedCreator.php.orig	2023-04-17 12:24:35.000000000 +0000
+++ ./lib/Creator/FeedCreator.php	2024-01-16 15:18:48.249315000 +0000
@@ -52,6 +52,9 @@
      */
     protected $encoding = "UTF-8"; //"ISO-8859-1";
 
+    protected $_timeout;  # lib/Creator/FeedCreator.php  line 238
+    protected $truncSize; # lib/Creator/PIECreator01.php line 29
+
     /**
      * Any additional elements to include as an associated array. All $key => $value pairs
      * will be included unencoded in the feed in the form
[15:20 dev-nginx01 dan /usr/local/share/UniversalFeedCreator] % 

dlangille added a commit to dlangille/UniversalFeedCreator that referenced this issue Jan 16, 2024
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Jan 16, 2024
dlangille added a commit to FreshPorts/freshports that referenced this issue Jan 16, 2024
It was never used, and not declared on the class.

This causes an error with PHP 8.3

re: flack/UniversalFeedCreator#16
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Jan 16, 2024
patches have been sent upstream via:

  flack/UniversalFeedCreator#16

(cherry picked from commit 03e3b84)
@flack flack closed this as completed in #17 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant