Improve robustness against misconfiguration

flack · Oct 8, 2019 · 663bcc8 · 663bcc8
1 parent 876d54b
commit 663bcc8
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/midcom/admin/folder/management.php b/lib/midcom/admin/folder/management.php
@@ -130,10 +130,12 @@ public static function list_styles($up = 0, $prefix = '/', $spacer = '') : array
     public static function list_theme_styles(array $styles) : array
     {
         $theme_styledir = OPENPSA2_THEME_ROOT . '/' . midcom::get()->config->get('theme') . '/style';
+        if (is_dir($theme_styledir)) {
         $finder = new Finder();
-        foreach ($finder->directories()->in($theme_styledir) as $dir) {
+            foreach ($finder->directories()->in($theme_styledir) as $dir) {
-            $label = preg_replace('/.+?\//', '&nbsp;&nbsp;', $dir->getRelativePathname());
+                $label = preg_replace('/.+?\//', '&nbsp;&nbsp;', $dir->getRelativePathname());
-            $styles['theme:/' . $dir->getRelativePathname()] = $label;
+                $styles['theme:/' . $dir->getRelativePathname()] = $label;
+            }
         }
         return $styles;
     }