Return "normal" for get rangeStart and rangeEnd #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramus
approved these changes
Feb 3, 2024
johannesodland
force-pushed
the
view-timeline-get-set-range
branch
from
44d9183
to
d864f6d
Compare
johannesodland
force-pushed
the
view-timeline-get-set-range
branch
from
d864f6d
to
3a60c5d
Compare
|
@bramus Thanks for letting me know 🙏 I've rebased the branch, and the tests are now passing :) |
flackr
approved these changes
Feb 6, 2024
bramus
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should return the string "normal" for rangeStart and rangeEnd (when specified as normal), and not a TimelineRangeOffset.
This change makes
view-timeline-get-set-range.htmlpass again, given that it is run on an uncompressed build (#200) and that we have a proper implementation of CSSNumericValue.parse() (#206).