This repository has been archived by the owner on Nov 21, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After many trials and errors on the trail of @luceos, I managed to find a solution that satisfies most (all ?) of the problems we had:
The following solutions were tested without success:
PostStream.posts()
Discussion.postIds()
It looks like something is reordering the posts after the Mithril object is returned from
PostStream.views()
, probably based on the content ofdata-index
,data-number
ordata-id
. Given the wayPostStream
gives these numbers out there is no way to push an item with a valid, yet non-duplicated value of index/number/id without forcing to change all the numbers from all posts until the end of the discussion.The current solution also works if we push ads items directly in the stream (they don't get reordered randomly). However, this breaks the
PostStreamScrubber
.